Hi Richard,
Comments inline. But before that, after doing some tests, I found out that we need to keep some version of RAND_poll (the patch removes it, and then the system does not seem to like that; something about unresolved symbols and stuff ;-) ). A google search returns this message ID with a random device and a RAND_poll implementation for VxWorks: <adighp$ven$[EMAIL PROTECTED]> but I am not sure how portable or how good it is. We could also just leave a blank implementation and force the user to seed the PRNG themselves. Your call. > Hello, > > I've finally started looking at your VxWorks patch. It looks good, > except for two things I strongly disagree with: > > 1. The change in Makefile.org requires GNU make. Sorry, we can't > assume that, so I wonder if you have some different solution to get > libs only. Perhaps something like: all: Makefile.ssl sub_libs sub_exec sub_test and then have clones of current sub_all target looping through their respective directories? > 2. As far as I can see, splitting up the arguments to makedepend > with -- like you do is not necessary, and actually > counterproductive, at least according to the manual I have. I am not sure why do you think it is counterproductive, since without -- makedepend does not work. The issue comes up when there are various options within CFLAGS that start with -f, which is very common when compiling for VxWorks. For example, with these options in CFLAGS: -fvolatile -fno-builtin -fno-for-scope -fsigned-char Solaris 8 makedepend prints (after a couple of warnings about other options from CFLAGS): makedepend: error: cannot open "signed-char" and does not update the Makefile at all. This leads me to believe that it tries to open a makefile named signed-char, according to makedepend's own "-f<makefile>" syntax. So, the proper way to make it work is to put CFLAGS between the double dashes. The other way would be to add '-fMakefile.ssl' after CFLAGS on every call to force the proper Makefile, but we would need to make sure that every incarnation of makedepend will use the *last* -f<makefile> option as the name of the current Makefile. Solaris seems to be OK. Cheers, Zoran Milojevic ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
