Richard Levitte wrote:
Hello Richard,

  OpenSSL CVS Repository
  http://cvs.openssl.org/
  ____________________________________________________________________________

  Server: cvs.openssl.org                  Name:   Richard Levitte
  Root:   /e/openssl/cvs                   Email:  [EMAIL PROTECTED]
            ^^^^^^^^^^^^^^
Is that really a good idea ?

  Module: openssl                          Date:   11-Dec-2002 07:59:18
  Branch: HEAD                             Handle: 2002121106591600
  Modified files:
    openssl/crypto/des      des.h des_old.h

  Log:
    Since HEADER_DES_H has been the protector of des.h since libdes
    (before SSLeay, maybe?), it's better to have that macro protect
    the compatibility header des_old.h.  In the new des.h, let's use
    a slightly different protecting macro.
[...]
Index: openssl/crypto/des/des.h
============================================================
$ cvs diff -u -r1.42 -r1.43 des.h
--- openssl/crypto/des/des.h 26 Mar 2002 14:28:04 -0000 1.42
+++ openssl/crypto/des/des.h 11 Dec 2002 06:59:16 -0000 1.43
@@ -56,8 +56,8 @@
* [including the GNU Public Licence.]
*/
-#ifndef HEADER_DES_H
-#define HEADER_DES_H
+#ifndef HEADER_NEW_DES_H
+#define HEADER_NEW_DES_H
[...]

I think it would be better to use something like:
#ifndef HEADER_OPENSSL_DES_H
#define HEADER_OPENSSL_DES_H

No other module could use this protector unintentionally...

Bye

Goetz

--
Goetz Babin-Ebell, TC TrustCenter AG, http://www.trustcenter.de
Sonninstr. 24-28, 20097 Hamburg, Germany
Tel.: +49-(0)40 80 80 26 -0,  Fax: +49-(0)40 80 80 26 -126

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to