This isn't a big one, but the HP ANSI C (and the HP ANSI C++) compiler give
the following warnings when building crypto/pkcs12/p12_npas.c:

cc: warning 5004: Uninitialized variable "pbe_iter" in function
"newpass_p12" (5004)
cc: warning 5004: Uninitialized variable "pbe_saltlen" in function
"newpass_p12" (5004)
cc: warning 5004: Uninitialized variable "pbe_nid" in function "newpass_p12"
(5004)

This is easily addressed with the following one-line change:

$ diff -c p12_npas.c.orig p12_npas.c
*** p12_npas.c.orig     Sat Dec 30 20:12:57 2000
--- p12_npas.c  Thu Feb 20 17:12:51 2003
***************
*** 107,113 ****
  {
        STACK_OF(PKCS7) *asafes, *newsafes;
        STACK_OF(PKCS12_SAFEBAG) *bags;
!       int i, bagnid, pbe_nid, pbe_iter, pbe_saltlen;
        PKCS7 *p7, *p7new;
        ASN1_OCTET_STRING *p12_data_tmp = NULL, *macnew = NULL;
        unsigned char mac[EVP_MAX_MD_SIZE];
--- 107,113 ----
  {
        STACK_OF(PKCS7) *asafes, *newsafes;
        STACK_OF(PKCS12_SAFEBAG) *bags;
!       int i, bagnid, pbe_nid = 0, pbe_iter = 0, pbe_saltlen = 0;
        PKCS7 *p7, *p7new;
        ASN1_OCTET_STRING *p12_data_tmp = NULL, *macnew = NULL;
        unsigned char mac[EVP_MAX_MD_SIZE];

I've been doing this for the past few 0.9.6* releases (and 0.9.7) without
introducing any problems, so I thought I'd pass it back to you.

Regards,
James
--
James A. Drenter
Planning, Architecture, and Technology Infrastructure Team
Hewlett-Packard Services Americas / Operations and I.T.
Internet: [EMAIL PROTECTED]

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to