[EMAIL PROTECTED] - Mon Mar 31 13:12:19 2003]:

> The code fails because of the following:
> 
> 1. title is empty --> indent will not be incremented
> 2. if (BIO_printf(bp,"%*s",indent, "") <= 0) return 0;
>     This printf tries to print an empty string.
> 
> Printf returns in this case a zero which is correct and not an error.
> There are two possible patches - accept a zero or don't print. the
> attached patch use the second option. I used 0.9.7a for diff and the
> file is crypto/x509v3/v3_prn.c.

Nice catch!  Actually, from looking at the rest of the file, I'm surprised the return 
value of that particular BIO_printf() is tested at all, but there are probably 
hysterical raisins behind that one.

Anyway, I've applied your patch and committed.  Thank you.

Ticket resolved.

-- 
Richard Levitte
[EMAIL PROTECTED]
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to