I've the following concerns about your patch:

1. Why the change of CFLAGS and LDFLAGS?  Your change will only work 
with shared libraries (because -lcrypto is lacking) and only if OpenSSL 
is already installed (which means that if you build the demos before 
installing OpenSSL, the build will fail or build against whatever's 
installed, which may be an older OpenSSL).

2. Why do you define OPENSSL_NO_KRB5?  Wouldn't it be better to include 
openssl/opensslconf.h?  It's possible that openssl/opensslconf.h needs 
to be included by some more of the exported OpenSSL header files, and in 
that case, that's the correct change to make.

[EMAIL PROTECTED] - Sun Nov 16 17:23:27 2003]:

> I hate broken demos...
> 
> The attached patch fixes various small things in the demos.  Things
> like
> #define OPENSSL_NO_KRB5, #include <string.h>, missing certs, and the
> like.


-- 
Richard Levitte
[EMAIL PROTECTED]
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to