Re: [openssl.org #903] [PATCH] Defect fix for NetWare Support in OpenSSL 0.9.8

[Andy Polyakov]

Fix applied, and will be visible in tomorrow's snapshot.  Thanks for the 
contribution.

Ticket resolved.
Following caught my eye. In crypto/rand/rand_nw.c:
+ #ifdef __MWERKS__
        asm
        {
           rdtsc
           mov tsc, eax
        }
+ #else
+       asm volatile("rdtsc":"=A" (tsc));
+ #endif
As far as I understand patch adds support for gcc. As I find it very 
hard to believe that gcc for Netware is very much different for any 
other platform, shouldn't suggested code rather look as following:

#elif defined(__GNUC__) && __GNUC__>=2
        asm volatile("rdtsc":"=a"(tsc)::"edx");
#endif
I mean it's important to tell compiler that edx is clobbered as result 
of rdtsc. As well as depict that the line is specific to certain 
compiler. But for safety sake, can you confirm that the above compiles 
before we correct it. A.

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]