On September 27, 2004 02:02 pm, Richard Levitte - VMS Whacker wrote: > In message <[EMAIL PROTECTED]> on Mon, 27 Sep > 2004 13:41:18 -0400, Geoff Thorpe <[EMAIL PROTECTED]> said: > > geoff> Well eng_padlock.c is #ifdef'd out unless we are on a > geoff> "supported" platform, so I don't think portability of the > geoff> include is quite so difficult. It'd be safe to include alloca.h > geoff> I think. OTOH, we'd ideally move all includes inside the > geoff> preprocessor checks to avoid problems on platforms that don't > geoff> support this engine, but we need to include certain headers to > geoff> perform those preprocessor checks - so I'd put alloca.h and any > geoff> other header unrelated to the preprocessor checks down inside > geoff> the #ifdef-protected code. > > Something like the attached patch?
Quick reaction without checking the code properly. No, I think the issue is that further down there is other preprocessor logic that checks whether the compiler is gcc, whether it's 386-only, [etc]. The inclusion of headers like alloca.h where "pure portability" can't be ensured (and isn't desired anyway) should probably be moved down into there. The OPENSSL_NO_*** checks you moved are related to whether the engine(s) are "Configure"d out of the build rather than whether the code itself decides what (and what not) to compile. Cheers, Geoff -- Geoff Thorpe [EMAIL PROTECTED] http://www.geoffthorpe.net/ ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
