In message <[EMAIL PROTECTED]> on Sun, 17 Jul 2005 20:01:24 -0700 (PDT), dean gaudet <[EMAIL PROTECTED]> said:
dean> On Mon, 18 Jul 2005, [EMAIL PROTECTED] wrote: dean> dean> > Unless I do the following I get the "Meaningless use of exression" dean> > from the compiler: dean> > dean> > diff -ru openssl-0.9.8/crypto/bn/bn_recp.c openssl-0.9.8-QNX/crypto/bn/bn_recp.c dean> > --- openssl-0.9.8/crypto/bn/bn_recp.c 2005-04-26 22:53:13.000000000 +0400 dean> > +++ openssl-0.9.8-QNX4/crypto/bn/bn_recp.c 2005-07-17 22:44:12.000000000 +0400 dean> > @@ -204,8 +204,10 @@ dean> > ret=1; dean> > err: dean> > BN_CTX_end(ctx); dean> > - if(dv) bn_check_top(dv); dean> > - if(rem) bn_check_top(rem); dean> > + if(dv) dean> > + bn_check_top(dv); dean> > + if(rem) dean> > + bn_check_top(rem); dean> > return(ret); dean> dean> i'm surprised the compiler isn't still bitching... dean> dean> there's a bug here... dean> dean> see crypto/bn/bn.h -- bn_check_top() is defined to an empty dean> string when BN_DEBUG is undefined... this can cause all sorts of dean> havoc with a sequence like the above... the compiler is really dean> seeing if(dv) if(rem) return(ret); ... nasty. Incorrect. The compiler will see 'if(dv) ; if(rem) ; return(ret)'. That's perfectly OK. Cheers, Richard ----- Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. -- Richard Levitte [EMAIL PROTECTED] http://richard.levitte.org/ "When I became a man I put away childish things, including the fear of childishness and the desire to be very grown up." -- C.S. Lewis ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager [EMAIL PROTECTED]
