David Schwartz wrote:

> Yep, this code is broken. That is not a particularly good fix though because
> errors can be lost.

I guessed as much :-).

> The simplest and probably best fix is a new function, ERR_get_count() that
> returns the number of entries on the error stack. Callers that need to do
> the kind of thing done above can check if the stack size changed.

Yes, please. Is one of the existing developers willing to do that or
should I do it and send a patch?

> It's much easier to see the better ways *after* you've done it.

Very true.

Erik
-- 
+-----------------------------------------------------------+
  Erik de Castro Lopo
+-----------------------------------------------------------+
"If only Muslims were clever politically, they could take over the United 
States and replace its constitutional govt. with a caliphate."
-- Siraj Wahaj, American convert to Islam
   http://www.kashmirtelegraph.com/jagan.htm
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to