On Tue, Jun 03, 2008 at 11:37:02AM -0400, Geoff Thorpe wrote: > > A quick skim of this patch seems to indicate that it makes sense, though the > litmus test will be to get some kind of regression coverage. Eg. do > connections get left dangling in any common scenarios?
Darryl (who wrote the patch) has a set of regression tests for nonblocking operation with OpenSSL. He posted about it here way back in 2006 when he originally pointed out this problem. It's kind of hard to figure out which message in some of these old, old mailing list threads actually has which patch or pointer to an external software distribution embedded in it -- maybe he can just tell us again where to fetch them from? The thing that's not 100% obvious about this patch is the mechanism by which WANT_READ or WANT_WRITE propagate back up to the application code. I believe what occurs is that, in the cases in which the patch makes it possible for SSL_shutdown to return -1, the BIO has already set the error for us and nothing higher up than the code in s3_lib/s3_pkt changes it. I'd appreciate confirmation of this from Darryl as well. Thor ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
