Hello All,
Currently, EC_POINT_cmp (from ec_lib.c) returns 0 in case of
group->meth->point_cmp==0 or other error.
However, ec_GF2m_simple_cmp, ec_GFp_simple_cmp and other comparison functions
return 0 if the points are equal, or -1 on error.
Should we apply the following patch?
Index: ec_lib.c
===================================================================
--- ec_lib.c (revision 9888)
+++ ec_lib.c (working copy)
@@ -1061,12 +1061,12 @@
if (group->meth->point_cmp == 0)
{
ECerr(EC_F_EC_POINT_CMP, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
- return 0;
+ return -1;
}
if ((group->meth != a->meth) || (a->meth != b->meth))
{
ECerr(EC_F_EC_POINT_CMP, EC_R_INCOMPATIBLE_OBJECTS);
- return 0;
+ return -1;
}
return group->meth->point_cmp(group, a, b, ctx);
}
--
Best regards,
Maxim Masiutin
Ritlabs SRL
http://www.ritlabs.com/
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [email protected]
