> [[email protected] - Wed Jul 01 05:41:07 2009]: > > > Jivin Stephen Henson via RT lays it down ... > > > > The equivalent to the two configure options can be done by including > > -Dfoo to Configure, for example Configure [options] -DHAVE_CRYPTODEV > . > > Ok, thats works for me if it's the preferred solution. >
OK, that has been added. It's unfortunate that there is a need to enable digests separately because it is possible at the ENGINE level to selectively enable algorithm implementations. Presumably this is to cover cases where applications just blindly use all algorithms and have no option to avoid using digests. > > This patch also does considerably more than the above description, > > adding new symmetric algorithms, changing the behaviour of existing > code > > etc. This should preferably be split into smaller patches which can > be > > more easily analysed with full descriptions of the reasoning for > changes. > > Sorry about that, I'll sync up with whatever changes have gone in and > generate new patches for the cryptodev engine related bits. > > Should they appear in new "rt" tickets of their own or keep it within > this > one ? > I'll apply some of the bits where I know what they do. The main bit I wasn't sure about was the reason for a change to a static fd in get_dev_crypto(): there was no comment in the ticket of the patch as to why this was done. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
