On Fri, 2009-09-04 at 14:26 +0200, Michael Tüxen wrote:
> On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote:
>
> >> [[email protected] - Fri Sep 04 09:39:52 2009]:
> >>
> >>
> >> Still wrong casts....I hope that's it now....
> >>
> >
> > A fair number of the casts seem to be unnecessary for example in
> > RAND_bytes(), OPENSSL_malloc() and HMAC(). Do you get warnings on your
> > system without them?
> The cast in RAND_bytes() is not needed, but OPENSSL_malloc returns a
> void*,
> so shouldn't you cast it to the corresponding type? I think the casts in
> HMAC are the ones you need to match the signature of HMAC. If you
> get warnings or not depends on the specific compiler, I think.
Casts from/to void* should not be necessary on C compilers compliant to
standards. C++ might be different though.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [email protected]
