Thanks. That's good advice. BTW, I've finished implementing everything except gets(). Other implementations I've seen seem to be able to get away with not having it, but my unit tests are failing because of it.
Phillip On Mon, Apr 12, 2010 at 2:47 PM, Ray Satiro <[email protected]> wrote: > --- On *Mon, 4/12/10, Phillip Hellewell <[email protected]>* wrote: > > > Do you think it's ok to set my type to just BIO_TYPE_SOURCE_SINK, or do I > need to set it to > (BIO_TYPE_SOURCE_SINK | > some_magic_number_that_hopefully_noone_else_is_using)? > > Phillip > > Really it depends what's being called whether you are going to keep it > generic or there's some advantage to imitate a BIO_TYPE_FILE or something. > Based on what you've described you could imitate a specific type, but the > disadvantage to that is that if/when OpenSSL dev team changes that specific > type you could have a problem, like say ptr wasn't in use but then they > changed the type so it is. Also I really don't see any advantage to making > your own magic number, because dev team could just end up using that number > at some point and again problem. > > >
