Hi, I have just checked the current state of HEAD after 22627. Although laborious, the changes seem fine to me. All occurrences are handled.
Best regards Robin On Jun 11, 2012, at 6:48 PM, Michael Tuexen wrote: > > On Jun 11, 2012, at 4:36 PM, Andy Polyakov wrote: > >>> On side note. Looking at first getsockopt in bss_dgram.c. In non-Windows >>> case it passes pointer to timeval and says it's sizeof(int) large... How >>> would non-Windows BIO_CTRL_DGRAM_GET_RECV_TIMEOUT work when ret is >>> initialized to 1? >> >> Consider http://cvs.openssl.org/chngview?cn=22627. Note that it doesn't >> use "heuristic" union approach on systems with IP_MTU and SCTP, assuming >> that they are modern enough to provide even socklen_t. > OK. Robin: Can you please double check? >> >> As for Linux-specific code reuse. What prevents us from removing all >> occurrences of defined(OPENSSL_SYS_LINUX) except for first one? > What if other platforms implement IP_MTU, but it has a different > semantic or requires a different option_value? I would keep it > Linux specific... > > Best regards > Michael >> ______________________________________________________________________ >> OpenSSL Project http://www.openssl.org >> Development Mailing List [email protected] >> Automated List Manager [email protected] >> > > ______________________________________________________________________ > OpenSSL Project http://www.openssl.org > Development Mailing List [email protected] > Automated List Manager [email protected] ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
