> Wow, indeed my first patch is useless taking in account presence > of OPENSSL_atomic_add and locking callback.
Why would you say something like this? It's very valuable input! > Surely, it would be good if > openssl will export this symbol, this is very important for tlsnappy > since it's compiling to shared library and non-exported symbols are not > visible for it. You didn't say anything about your platform, but by default it should be visible on Unix. But one can as well argue that application shouldn't have to care about it, instead one can set the callback from withing libcrypto, so that symbol in question doesn't have to be exported. So assuming that you run on x86[_64] modify OPENSSL_cpuid_setup in crypto/cryptlib.c, by declaring int OPENSSL_atomic_add(int *,int,int,void*,int) and adding CRYPTO_set_add_lock_callback(OPENSSL_atomic_add) at the end of OPENSSL_cpuid_setup. Questions are if your application operates correctly, and if it delivers expected performance (keep the other patch applied). ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
