Hi, Andy,
>>> Shall we settle for
>>> http://cvs.openssl.org/chngview?cn=23135?
>
> http://cvs.openssl.org/chngview?cn=23143, more intuitive.
Seems OK.
Tests for openssl-SNAP-20121220:
$ patch -p1 < ../test2814789.121219.patch # With 2 conflict in
test/Makefile, manual resolved
$ make && ( cd test && make test_gost2814789) # Manual started, because `make
test' stopped at test_ocsp
$ make && ( cd test && ../util/shlib_wrap.sh ./gost2814789t 5000000000000 1)
Passed.
> There is problem with overflow in another part of the suggested patch,
> namely in "if (c->count<8 && c->bytes_left)" in gost_imit_final. Indeed,
> count is incremented by 8 *unconditionally* while ceiled by 2040 only in
> key_meshing case.
Right, but current version ccgost don't have way for initialization
ossl_gost_imit_ctx with key_meshing==0, because my tests don't detect this
problem.
> Note that declaring it short makes it worse (and
> signed is much more worse that unsigend:-)
Right, use `short` type as implicit assertion not good (poor performance...).
May be add `OPENSSL_assert(0 == c->count%8 && 1024 >= c->count)' for explicit
assertion?
>> Attachment "test2814789.121219.patch" (63 KB), change from 121214-1:
>> - Add test cases for CFB and CNT modes with clear text length 5 MB and,
>> optional, 4 GB.
>
> Once we settle on solution, it will be committed. Cheers.
Waiting, don't worry. See also GOST R 34.11-94 regression test in PR #2918
--
Sorry for my bests English.
Serguei E. Leontiev w:+7(495)939-2382 USSR,Moscow,Universitetskij 13
Sternberg Astronom. w:+7(495)780-4820 USSR,Moscow,127018,Sushchevskij val 16-5
Institute, MSU h:+7(495)318-1146 USSR,Moscow,113303,Kakhovka 6-40
m:+7(916)686-1081 SMS: <http://www.mts.ru/sms>
<http://lnfm1.sai.msu.ru/~leo>
19.12.2012, в 21:27, Andy Polyakov via RT написал(а):
>>> Shall we settle for
>>> http://cvs.openssl.org/chngview?cn=23135?
>
> http://cvs.openssl.org/chngview?cn=23143, more intuitive.
>
>
> ______________________________________________________________________
> OpenSSL Project http://www.openssl.org
> Development Mailing List [email protected]
> Automated List Manager [email protected]
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [email protected]
