The null check against pub_key should come before dereferencing pub_key
in bn_wexpand(pub_key, ...).
---
engines/e_ubsec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/engines/e_ubsec.c b/engines/e_ubsec.c
index aa5709b..bd47690 100644
--- a/engines/e_ubsec.c
+++ b/engines/e_ubsec.c
@@ -947,9 +947,9 @@ static int ubsec_dh_generate_key(DH *dh)
if (dh->pub_key == NULL)
{
pub_key = BN_new();
+ if (pub_key == NULL) goto err;
pub_key_len = BN_num_bits(dh->p);
if(bn_wexpand(pub_key, dh->p->top) == NULL) goto err;
- if(pub_key == NULL) goto err;
}
else
{
--
1.7.10.4
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [email protected]
