On Mon Apr 14 11:52:20 2014, [email protected] wrote: > Well... > With this check 'make test' fails with: > > CMS => PKCS#7 compatibility tests > signed content DER format, RSA key: generation error > make[1]: *** [test_cms] Error 1 > >
Can't reproduce that here. Anyone else seeing this? > > > On 14 April 2014 00:16, Andrey Kulikov <[email protected]> wrote: > > > In 1.0.1g duplicated check for (!pcerts) where removed. > > > > Had an impression that second appearance was check for (!*pcerts) (as in > > all other functions). > > No it has to be different in this case. The *pcerts value can be legitimately NULL in CMS_add0_cert because the certificate choices structure might not have been allocated yet. That turns the following loop into no op (no certificates to look through) and a new *pcerts value is then allocated using CMS_add0_CertificateChoices. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
