On Sat, Jul 19, 2014 at 9:33 AM, Salz, Rich <[email protected]> wrote:
> You are preaching to the choir. Look at the rsalz-monolith branch in > akamai/openssl on github. > If you have a patch to go into that, I'll take it right away. > > > I'm sure it is moving in a good direction, but it would take me way too much time to figure out what is in there... The first commit is huge and affects many issues other than portability. Possibly it can only be "taken on faith" unless someone has extraordinary powers of concentration and adequate time. If it were me thinking about portability, which is just a subset of what rsalz-monolith deals with... Stick with just apps/ for now. 1. Do we want to reformat the code? Run a well-used tool to reformat all of apps/ at once and commit that by itself as long as it still builds and passes tests on a few platforms and a visual spotcheck doesn't find anything disturbing. 2. Delete commented out and otherwise disabled code (e.g., #ifdef undef, #ifdef WINDOWS_STUFF?, etc.) unless it is commentary in nature, in one commit. 3. What abstractions are required to get rid of 70+% of platform-related ifdefs? A more portable way to call select() is not the point; an abstraction to wait on file descriptor events and/or console might be depending on density of ifdefs. Add those abstractions in the minimal chunks that make sense together. -- Born in Roswell... married an alien... http://emptyhammock.com/ http://edjective.org/
