The following fails for a good key (produced by OpenSSL utility). It
returns 1 when it should return 0.

$ openssl dsa -in dsa-pub.pem -pubin -text -noout
read DSA key
pub:
    29:a1:21:67:5c:d8:85:b3:10:76:80:8a:78:af:0a:
    dd:1b:4b:92:76:75:cd:be:e9:05:8d:e7:71:ed:69:
    6b:b0:f9:e3:9b:bb:77:ff:f9:35:b9:b3:cc:02:b7:
    c5:35:ce:64:9b:b0:fa:63:84:8b:e7:ca:b3:0e:37:
    9f:57:12:25:47:b8:c4:9d:14:bb:e0:d1:9c:9a:b7:
    14:5e:af:20:c4:8d:bb:8f:3b:12:ba:17:f1:12:d4:
    98:29:f7:fa:4e:08:93:45:6d:3f:dd:93:03:a4:38:
    e2:02:2b:f5:84:a7:35:dc:34:12:d7:e6:eb:c4:32:
    f4:f2:a6:50:0e:80:eb:f1
P:
    00:a6:c2:20:18:e3:72:43:06:37:81:c3:0e:1e:ca:
    6e:7c:a7:91:d7:c9:70:52:70:3a:5e:bc:8d:54:c8:
    cd:d7:98:a0:79:88:4c:54:ff:7b:6a:50:e5:71:a4:
    78:26:9c:93:90:be:0f:d4:3e:13:02:77:bb:0a:e3:
    eb:48:e9:70:9c:0d:ef:bf:d6:52:03:2f:80:66:e1:
    06:3c:ab:52:c0:55:ae:03:fb:26:09:de:ed:2b:b6:
    ab:5c:e5:0d:29:61:f3:59:eb:ee:1d:7c:ac:ea:d6:
    64:20:75:53:7c:11:66:29:90:6b:24:09:6e:78:dd:
    13:37:61:df:76:2b:1e:53:eb
Q:
    00:a3:54:f2:e1:2c:f5:d7:95:87:ee:07:9c:0e:48:
    21:04:c0:10:b1:a1
G:
    20:0e:4f:0e:a5:07:24:42:52:9b:34:55:4d:e0:cd:
    5d:64:4b:7f:77:9e:82:99:5b:73:f2:dd:2f:df:8e:
    a8:b5:7d:b6:ec:0e:98:64:df:14:6d:78:04:a1:c8:
    50:2b:9b:ca:e5:cc:41:ca:bf:76:0a:ab:a9:c3:cb:
    e3:ed:e6:59:c4:a5:af:8e:b1:37:9a:c3:02:1c:f9:
    ed:06:2a:3b:16:fa:d6:5a:9b:8f:43:4e:cf:10:10:
    b9:4a:01:c0:5c:b5:4b:3f:f7:e1:66:e5:7d:6b:79:
    3b:30:7f:6a:4a:61:d8:88:30:7a:c3:7b:b2:1c:80:
    e0:1f:b5:f3:3c:42:ee:74
$ echo $?
1

*****

$ git diff apps/dsa.c
diff --git a/apps/dsa.c b/apps/dsa.c
index 5222487..974ce39 100644
--- a/apps/dsa.c
+++ b/apps/dsa.c
@@ -324,7 +324,11 @@ bad:
                fprintf(stdout,"\n");
                }

-       if (noout) goto end;
+       if (noout)
+               {
+               ret=0;
+               goto end;
+               }
        BIO_printf(bio_err,"writing DSA key\n");
        if      (outformat == FORMAT_ASN1) {
                if(pubin || pubout) i=i2d_DSA_PUBKEY_bio(out,dsa);

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           majord...@openssl.org

Reply via email to