Salz, Rich wrote:
Look like a bug and a reasonable fix.  Thanks.
It seems to me OpenSSL requires separator option always to be specified.

[SNIP]

On Mon, Oct 6, 2014 at 12:07 AM, Dmitry Belyavsky via RT 
<[email protected]<mailto:[email protected]>> wrote:
Hello OpenSSL Team,
[SNIP]

The output becomes correct when we specify -nameopt sep_comma_plus,utf8

The patch by Victor Wagner fixing this behaviour is attached.

Thank you!

--
SY, Dmitry Belyavsky

--- ../openssl-1.0.1i/crypto/asn1/a_strex.c     2014-07-22 23:41:23.000000000 
+0400
+++ crypto/asn1/a_strex.c       2014-10-05 19:45:32.790011154 +0400
@@ -414,6 +414,7 @@
                 sep_mv_len = 3;
                 break;

+               case 0:
                 case XN_FLAG_SEP_COMMA_PLUS:
                 sep_dn = ",";
                 sep_dn_len = 1;


switch(case) statement define default case. May be is better to change default case and to document default separator .

Which separator to use by default :
 - to be compatible with previous versions, i.e. sep_comma_plus_space
 - or in rfc2253 style , i.e. sep_comma_plus ?



I think that this is documentation issue only - user could use "composite" like oneline or own set of flags as 'separator' is required.

Pages x509 and X509_NAME_print_ex could be updated to detail that 'separator' flag is required.

Regards,
Roumen Petrov

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [email protected]

Reply via email to