Am 22.06.2015 um 21:49 schrieb Rich Salz:
The branch master has been updated
        via  75ba5c58c6b3b3326a6c3198100830afa120e7c3 (commit)
       from  389ebcecae2575188a4ff9566389ce694352be43 (commit)


- Log -----------------------------------------------------------------
commit 75ba5c58c6b3b3326a6c3198100830afa120e7c3
Author: Rich Salz <rs...@akamai.com>
Date:   Sat Jun 13 17:18:47 2015 -0400

     RT3907: avoid "local" in testssl script

     Reviewed-by: Richard Levitte <levi...@openssl.org>

-----------------------------------------------------------------------

Summary of changes:
  test/testssl | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/test/testssl b/test/testssl
index 7e834a7..cb8e56a 100644
--- a/test/testssl
+++ b/test/testssl
@@ -118,11 +118,10 @@ echo test sslv2/sslv3 with both client and server 
authentication via BIO pair an
  $ssltest -bio_pair -server_auth -client_auth -app_verify $CA $extra || exit 1

  test_cipher() {
-  local cipher=$1
-  local protocol=$2
+    _cipher=$1

It seems "_cipher" is never used and instead the function still uses "cipher" (which is the variable which is set elsewhere before calling the function "test_cipher").

      echo "Testing $cipher"
      prot=""
-    if [ $protocol = "SSLv3" ] ; then
+    if [ $2 = "SSLv3" ] ; then
        prot="-ssl3"
      fi
      $ssltest -cipher $cipher $prot

Regards,

Rainer
_______________________________________________
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Reply via email to