Il 22/06/2015 23:14, Stephen Henson via RT ha scritto:
On Sun Jun 21 19:00:55 2015, [email protected] wrote:
Yet another version after some refactorings that landed in master.

Please, pretty please, with sugar on top, could anyone review this code
so that it can get merged?

It's becoming a difficult exercise to keep track of upstream changes and
adapt the patch every single time...


I'm currently looking at the OpenSSL PSK code. I'll look into incopoorating
your changes (in a modified form) as part of that so there is no need to keep
it up to date with the changing master branch.

Great, thank you! If you have questions on the implementation just ask. It should me mostly straightforward with the RFC at hand, with a small section copied as-is from the plain RSA code.

I hope to revise the PSK code and make it more flexible so it can support
{RSA,DH,ECDH}+PSK more cleanly.

FYI, I can tell you the cause of the GCM crash: the cipher structure isn't set
up correctly in your patch, it needs to use SSL_AEAD not SSL_SHA256 (compare it
with other GCM entries).

A-ha! That explains the silly mistake, thank you.

Cheers,
--
Giuseppe D'Angelo | [email protected] | Software Engineer
KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908
KDAB - The Qt Experts

Attachment: smime.p7s
Description: Firma crittografica S/MIME

_______________________________________________
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Reply via email to