Patch attached. This is just a little cleanup change to fix not everything using the OPENSSL_armcap constants. (Existing ones already are using them, so I'm assuming this is okay.)
David -- Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4341 Please log in as guest with password guest if prompted
>From a7fdfa143c2d8dbe8a738662475a033e2cf1a52f Mon Sep 17 00:00:00 2001 From: David Benjamin <[email protected]> Date: Tue, 23 Feb 2016 11:41:55 -0500 Subject: [PATCH] Consistently use arm_arch.h constants in armcap assembly code. Most of the assembly uses constants from arm_arch.h, but a few references to ARMV7_NEON don't. Consistently use the macros everywhere. --- crypto/bn/asm/armv4-mont.pl | 2 +- crypto/chacha/asm/chacha-armv4.pl | 2 +- crypto/poly1305/asm/poly1305-armv4.pl | 2 +- crypto/sha/asm/sha512-armv4.pl | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/bn/asm/armv4-mont.pl b/crypto/bn/asm/armv4-mont.pl index 7017ad5..6fb5bb4 100644 --- a/crypto/bn/asm/armv4-mont.pl +++ b/crypto/bn/asm/armv4-mont.pl @@ -121,7 +121,7 @@ bn_mul_mont: #ifdef __APPLE__ ldr r0,[r0] #endif - tst r0,#1 @ NEON available? + tst r0,#ARMV7_NEON @ NEON available? ldmia sp, {r0,r2} beq .Lialu add sp,sp,#8 diff --git a/crypto/chacha/asm/chacha-armv4.pl b/crypto/chacha/asm/chacha-armv4.pl index 55ebc9e..3e3c34c 100755 --- a/crypto/chacha/asm/chacha-armv4.pl +++ b/crypto/chacha/asm/chacha-armv4.pl @@ -214,7 +214,7 @@ ChaCha20_ctr32: # ifdef __APPLE__ ldr r4,[r4] # endif - tst r4,#1 + tst r4,#ARMV7_NEON bne .LChaCha20_neon .Lshort: #endif diff --git a/crypto/poly1305/asm/poly1305-armv4.pl b/crypto/poly1305/asm/poly1305-armv4.pl index 2cce9df..591e530 100755 --- a/crypto/poly1305/asm/poly1305-armv4.pl +++ b/crypto/poly1305/asm/poly1305-armv4.pl @@ -108,7 +108,7 @@ poly1305_init: and r5,r5,r3 #if __ARM_MAX_ARCH__>=7 - tst r12,#1 @ check for NEON + tst r12,#ARMV7_NEON @ check for NEON # ifdef __APPLE__ adr r9,poly1305_blocks_neon adr r11,poly1305_blocks diff --git a/crypto/sha/asm/sha512-armv4.pl b/crypto/sha/asm/sha512-armv4.pl index 56bb9fd..9e3c4db 100644 --- a/crypto/sha/asm/sha512-armv4.pl +++ b/crypto/sha/asm/sha512-armv4.pl @@ -287,7 +287,7 @@ sha512_block_data_order: #ifdef __APPLE__ ldr r12,[r12] #endif - tst r12,#1 + tst r12,#ARMV7_NEON bne .LNEON #endif add $len,$inp,$len,lsl#7 @ len to point at the end of inp -- 2.7.0.rc3.207.g0ac5344
-- openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
