Hello, On Fri, May 24, 2019 at 5:21 PM Matt Caswell <m...@openssl.org> wrote:
> > On 24/05/2019 15:10, Richard Levitte wrote: > > If we go with the idea that an approval also involves approving what > > branches it goes to, then what happens if someone realises after some > > time that a set of commits (a PR) that was applied to master only > > should really also be applied to 1.1.1? Should the approval process > > start over from scratch, i.e. all approvals that went to master should > > be scratched and replaced with a new set of approvals (in principle)? > > No. If the PR was approved for master and applied to master then no > problem - it > stays in master. If it is later realised that it needs to be backported to > other > branches then, yes, new approvals need to be sought for that change to > *those > branches*. > > As far as I was aware we've always done this. > > This is essential in my mind. A change for one branch does not always make > sense > in another branch. So you can't just say "I approve this change" and *then* > worry about what branches it applies to. A change only makes sense in the > context of the branch it applies to. > > I agree with Matt. For example, a patch providing new functionality cat be cleanly applicable to master and stable branches, but if it is applied to a stable branch, it breaks the policy. -- SY, Dmitry Belyavsky