In message <[email protected]> on Sat, 29 Dec 2018 17:08:46 +0100 (CET), Richard Levitte <[email protected]> said:
> In message <[email protected]> on Sat, 29 Dec 2018 > 14:19:47 +0100, "C.Wehrmeyer" <[email protected]> said: > ... > > What's wrong with that, you ask? Let me show you how I'd have done > > that: > > > > > static const unsigned char ssl3_pad_1[] = > > > { > > > "66666666" > > > "66666666" > > > "66666666" > > > "66666666" > > > "66666666" > > > "66666666" > > > }; > > > > > > static const unsigned char*ssl3_pad_2[] = > > > { > > > "\\\\\\\\\\\\\\\\" > > > "\\\\\\\\\\\\\\\\" > > > "\\\\\\\\\\\\\\\\" > > > "\\\\\\\\\\\\\\\\" > > > "\\\\\\\\\\\\\\\\" > > > "\\\\\\\\\\\\\\\\" > > > }; > > > > So, no. I don't trust anyone. Especially not this mess of a code. > > You do know that your string insert NUL bytes, right? If you have a > look at how they're used, you might see why those stray NUL bytes > aren't a good thing. Never mind this remark... For some reason, my brain added commas after each partial string. Meh... -- Richard Levitte [email protected] OpenSSL Project http://www.openssl.org/~levitte/ -- openssl-users mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users
