On Wed, Sep 20, 2017 at 2:37 AM, Matt Riedemann <mriede...@gmail.com>
wrote:
On 9/19/2017 10:35 AM, Balazs Gibizer wrote:
> Hi,
>
> Similar to my earlier mail about not transforming legacy
notifications
> in the networking area [1] now I want to propose not to transform
> HostAPI related notifications.
> We have the following legacy notifications on our TODO list [2] to
be
> transformed:
> * HostAPI.power_action.end
> * HostAPI.power_action.start
> * HostAPI.set_enabled.end
> * HostAPI.set_enabled.start
> * HostAPI.set_maintenance.end
> * HostAPI.set_maintenance.start
>
> However os-hosts API has been depraceted since microversion 2.43.
The
> suggested replacement is os-services API. The os-services API
already
> emits service.update notification for every action on that API. So I
> suggest not to transform the above HostAPI notifications to the
> versioned notification format.
>
> Cheers,
> gibi
>
>
> [1]
>
http://lists.openstack.org/pipermail/openstack-dev/2017-September/121968.html
>
> [2] https://vntburndown-gibi.rhcloud.com/index.html
>
>
>
__________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
This also seems reasonable to me. I had to dig up what set_enabled was
for again, but now I remember, it's basically the same thing as
enable/disable a service in the os-services API, but only implemented
for the xenapi driver.
So yeah, +1 to not converting these to versioned notifications.
Cool, thanks.
As a side question: how do you keep track of the things we
purposefully
*aren't* going to implement for versioned notifications?
I remove them [2] from our TODO list[1] with a nice commit message
explaining the reason [3]. Do you feel we need something more user
facing documentations about these decisions?
Cheers,
gibi
[1] https://vntburndown-gibi.rhcloud.com/index.html
[2]
https://github.com/gibizer/nova-versioned-notification-transformation-burndown/commits/master/to_be_transformed
[3]
https://github.com/gibizer/nova-versioned-notification-transformation-burndown/commit/112a25aecf7e9b1f344840ae4ce150f70e75b634#diff-cd2b276ea9db6ffddf9aa78d871ab2e9
--
Thanks,
Matt
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
