Zhenguo, Thanks for bringing this up.
For #1, yes please indicate which file from Nova, so if anyone wanted to cross check for fixes etc can go look in Nova For #2, When you pick up a commit from Nova, please make sure the commit message in Mogan has the following * The gerrit change id(s) of the original commit, so folks can easily go find the original commit in gerritt * Add "Co-Authored-By:" tags for each author in the original commit so they get credit Also, Please make sure you do not alter any copyright or license related information in the header when you first copy a file from another project. Thanks, Dims On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu <niu.zgli...@gmail.com> wrote: > Hi all, > > I'm from Mogan team, we copied some codes/frameworks from Nova since we want > to be a Nova with a bare metal specific API. > About why reinventing the wheel, you can find more informations here [1]. > > I would like to know what's the decent way to show our respect to the > original authors we copied from. > > After discussing with the team, we plan to do some improvements as below: > > 1. Adds some comments to the beginning of such files to indicate that they > leveraged the implementation of Nova. > > https://github.com/openstack/mogan/blob/master/mogan/baremetal/ironic/driver.py#L19 > https://github.com/openstack/mogan/blob/master/mogan/console/websocketproxy.py#L17-L18 > https://github.com/openstack/mogan/blob/master/mogan/consoleauth/manager.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/engine/configdrive.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/engine/metadata.py#L18 > https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18 > https://github.com/openstack/mogan/blob/master/mogan/objects/aggregate.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/objects/keypair.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/objects/server_fault.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/objects/server_group.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/scheduler/client/report.py#L17 > https://github.com/openstack/mogan/blob/master/mogan/scheduler/filter_scheduler.py#L17 > > 2. For the changes we follows what nova changed, should reference to the > original authors in the commit messages. > > > Please let me know if there are something else we need to do or there are > already some existing principles we can follow, thanks! > > > > [1] https://wiki.openstack.org/wiki/Mogan > > > -- > Best Regards, > Zhenguo Niu > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Davanum Srinivas :: https://twitter.com/dims __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
