On 20 Sep 2017, at 9:25, Michael Still wrote:
> Dims, I'm not sure that's actually possible though. Many of these files > have been through rewrites and developed over a large number of years. > Listing all authors isn't practical. > > Given the horse has bolted on forking these files, I feel like a comment > acknowledging the original source file is probably sufficient. In Swift's repo, we acknowledge the original authors in a section of the AUTHORS file https://github.com/openstack/swift/blob/master/AUTHORS --John > > What is concerning to me is that some of these files are part of the "ABI" > of nova, and if mogan diverges from that then I think we're going to see > user complaints in the future. Specifically configdrive, and metadata seem > like examples of this. I don't want to see us end up in another "managed > cut and paste" like early oslo where nova continues to develop these and > mogan doesn't notice the changes. > > I'm not sure how we resolve that. One option would be to refactor these > files into a shared library. > > Michael > > > > > On Wed, Sep 20, 2017 at 5:51 AM, Davanum Srinivas <dava...@gmail.com> wrote: > >> Zhenguo, >> >> Thanks for bringing this up. >> >> For #1, yes please indicate which file from Nova, so if anyone wanted >> to cross check for fixes etc can go look in Nova >> For #2, When you pick up a commit from Nova, please make sure the >> commit message in Mogan has the following >> * The gerrit change id(s) of the original commit, so folks can >> easily go find the original commit in gerritt >> * Add "Co-Authored-By:" tags for each author in the original commit >> so they get credit >> >> Also, Please make sure you do not alter any copyright or license >> related information in the header when you first copy a file from >> another project. >> >> Thanks, >> Dims >> >> On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu <niu.zgli...@gmail.com> >> wrote: >>> Hi all, >>> >>> I'm from Mogan team, we copied some codes/frameworks from Nova since we >> want >>> to be a Nova with a bare metal specific API. >>> About why reinventing the wheel, you can find more informations here [1]. >>> >>> I would like to know what's the decent way to show our respect to the >>> original authors we copied from. >>> >>> After discussing with the team, we plan to do some improvements as below: >>> >>> 1. Adds some comments to the beginning of such files to indicate that >> they >>> leveraged the implementation of Nova. >>> >>> https://github.com/openstack/mogan/blob/master/mogan/ >> baremetal/ironic/driver.py#L19 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> console/websocketproxy.py#L17-L18 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> consoleauth/manager.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> engine/configdrive.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> engine/metadata.py#L18 >>> https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> objects/aggregate.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> objects/keypair.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> objects/server_fault.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> objects/server_group.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> scheduler/client/report.py#L17 >>> https://github.com/openstack/mogan/blob/master/mogan/ >> scheduler/filter_scheduler.py#L17 >>> >>> 2. For the changes we follows what nova changed, should reference to the >>> original authors in the commit messages. >>> >>> >>> Please let me know if there are something else we need to do or there are >>> already some existing principles we can follow, thanks! >>> >>> >>> >>> [1] https://wiki.openstack.org/wiki/Mogan >>> >>> >>> -- >>> Best Regards, >>> Zhenguo Niu >>> >>> ____________________________________________________________ >> ______________ >>> OpenStack Development Mailing List (not for usage questions) >>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject: >> unsubscribe >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> >> >> >> >> -- >> Davanum Srinivas :: https://twitter.com/dims >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
signature.asc
Description: OpenPGP digital signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev