in my opinion, idempotent scrip t is very necessary. for several reason
- there is already some idempotent logical in the script - it is common that this script failed by wrong configuration, after fix the config, ops will want to run this script again. On Tue, Nov 28, 2017 at 7:14 PM, Paul Bourke <paul.bou...@oracle.com> wrote: > I think this came up before at one stage. My position is I don't see the > need to ansible-ise small shell scripts. init-runonce is currently just an > easy to understand sequence of openstack commands provided to help people > test/demo their setups. Unless we want to make it more than that, i.e. make > it idempotent, customizable, etc. I don't see the need to wheel in Ansible. > > On 28/11/17 03:23, Jeffrey Zhang wrote: > >> hi >> >> check this [0]. I tried to convert it to ansible playbooks. >> >> [0] https://review.openstack.org/523072 >> >> On Tue, Nov 28, 2017 at 2:57 AM, Ravi Shekhar Jethani < >> rsjeth...@gmail.com <mailto:rsjeth...@gmail.com>> wrote: >> >> Hi, >> >> While exploring kolla-ansible I ran into a few issues with >> init-runonce script. This lead to following bugs and patches: >> >> https://launchpad.net/bugs/1732963 <https://launchpad.net/bugs/17 >> 32963> >> https://review.openstack.org/522221 >> <https://review.openstack.org/522221> >> https://review.openstack.org/521190 >> <https://review.openstack.org/521190> >> >> But it was highlighted that instead of fixing/changing the >> script, 'ansibilzing' it would be the ideal solution. >> Hence I hereby formally propose the same. >> >> My thoughts: >> * Playbook Name: init-stack.yml >> >> * Playbook path can be: >> kolla-ansible/ansible/init-stack.yml >> >> * The play can be executed like: >> $ kolla-ansible init-stack -i <inventory_file> >> >> * The cirros test image should be downloaded in /tmp >> >> * What should be the behavior if the play is run multiple times >> against the same stack? >> - some error message OR >> - simply ignore the action >> >> Kindly provide suggestions. >> >> -- >> Best Regards, >> Ravi J. >> >> ____________________________________________________________ >> ______________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> >> >> >> >> >> -- >> Regards, >> Jeffrey Zhang >> Blog: http://xcodest.me <http://xcodest.me/> >> >> >> ____________________________________________________________ >> ______________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib >> e >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Regards, Jeffrey Zhang Blog: http://xcodest.me
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev