Hi James, Thank you for the previous code review. I have pushed another patch. Also, I do not know how to reply to your review comments on gerrit, so I will reply to them here.
About the signed-off-message, I did not know that it wasn't a requirement for OpenStack, I assumed it was. I have removed it from the updated patch. Thank you, Aakash On Thu, Mar 15, 2018 at 11:34 AM, Aakash Kt <aakash...@gmail.com> wrote: > Hi James, > > Just a small reminder that I have pushed a patch for review, according to > changes you suggested :-) > > Thanks, > Aakash > > On Mon, Mar 12, 2018 at 2:38 PM, James Page <james.p...@ubuntu.com> wrote: > >> Hi Aakash >> >> On Sun, 11 Mar 2018 at 19:01 Aakash Kt <aakash...@gmail.com> wrote: >> >>> Hi, >>> >>> I had previously put in a mail about the development for openstack-ovn >>> charm. Sorry it took me this long to get back, was involved in other >>> projects. >>> >>> I have submitted a charm spec for the above charm. >>> Here is the review link : https://review.openstack.org/#/c/551800/ >>> >>> Please look in to it and we can further discuss how to proceed. >>> >> >> I'll feedback directly on the review. >> >> Thanks! >> >> James >> >> ____________________________________________________________ >> ______________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib >> e >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev