Does anyone know how this will work with services that are using cotyledon instead of oslo.service (for eliminating eventlet)?
Michael On Mon, Mar 26, 2018 at 5:35 AM, Sławomir Kapłoński <sla...@kaplonski.pl> wrote: > Hi, > > >> Wiadomość napisana przez ChangBo Guo <glongw...@gmail.com> w dniu >> 26.03.2018, o godz. 14:15: >> >> >> 2018-03-22 16:12 GMT+08:00 Sławomir Kapłoński <sla...@kaplonski.pl>: >> Hi, >> >> I took care of implementation of [1] in Neutron and I have couple questions >> to about this goal. >> >> 1. Should we only change "restart_method" to mutate as is described in [2] ? >> I did already something like that in [3] - is it what is expected? >> >> Yes , let's the only thing. we need test if that if it works . > > Ok, so please take a look at my patch for neutron if that is what we should > do :) > >> >> 2. How I can check if this change is fine and config option are mutable >> exactly? For now when I change any config option for any of neutron agents >> and send SIGHUP to it it is in fact "restarted" and config is reloaded even >> with this old restart method. >> >> good question, we indeed thought this question when we proposal the >> goal. But It seems difficult to test that consuming projects like Neutron >> automatically. > > I was asking rather about some manual test instead of automatic one. > >> >> 3. Should we add any automatic tests for such change also? Any examples of >> such tests in other projects maybe? >> There is no example for tests now, we only have some unit tests in >> oslo.service . >> >> [1] >> https://governance.openstack.org/tc/goals/rocky/enable-mutable-configuration.html >> [2] https://docs.openstack.org/oslo.config/latest/reference/mutable.html >> [3] https://review.openstack.org/#/c/554259/ >> >> — >> Best regards >> Slawek Kaplonski >> sla...@kaplonski.pl >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> -- >> ChangBo Guo(gcb) >> Community Director @EasyStack >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > — > Best regards > Slawek Kaplonski > sla...@kaplonski.pl > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
