On Fri, Jan 03, 2014 at 10:18:58AM -0500, Russell Bryant wrote: > On 01/03/2014 10:10 AM, Radomir Dopieralski wrote: > > I think that we can actually do a little bit better and remove many of > > the #noqa tags without forfeiting automatic checking. I submitted a > > patch: https://review.openstack.org/#/c/64832/ > > > > This basically adds a h302_exceptions option to tox.ini, that lets us > > specify which names are allowed to be imported. For example, we can do: > > > > [hacking] > > h302_exceptions = django.conf.settings, > > django.utils.translation.ugettext_lazy, > > django.core.urlresolvers. > > > > To have settings, _ and everything from urlresolvers importable without > > the need for the #noqa tag. > > > > Of course every project can add their own names there, depending what > > they need. > > Isn't that what "import_exceptions" is for? For example, we have this > in nova: > > import_exceptions = nova.openstack.common.gettextutils._ > > -- > Russell Bryant > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
I guess it could work too, but that would disable all warnings against these imports (unused imports, * imports, etc), right? I think a specific option is useful. -- Gabriel Pettier Software Engineer at CloudWatt.com 06 85 10 36 34 _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev