I'd be up for that 'dual' gating. It would help make sure that nothing major is breaking in the next version as well as the version released on pypi isn't also causing problems.
Although git head gating does seem odd, especially as git head/trunk is where things change (and should be allowed to break and change, change is good) and the level of false positives that would be raised might become to much of a pain. I'd rather not discourage innovation on trunk if we can; since this is what stable releases are for. Btw the sqlalchemy changes (unpinning) should be fine. Ivan did a couple of tests (basic stuff, not full integration). - https://review.openstack.org/#/c/64869/ - https://review.openstack.org/#/c/64881/ Both passed basic unit tests (full integration against real mysql, not sqlite will happen soon I hope with https://bugs.launchpad.net/taskflow/+bug/1265886). If we really need to I can push out a 0.1.2 with the unpinned version (one of the above reviews). -Josh From: Doug Hellmann <doug.hellm...@dreamhost.com<mailto:doug.hellm...@dreamhost.com>> Date: Friday, January 3, 2014 at 11:44 AM To: Joshua Harlow <harlo...@yahoo-inc.com<mailto:harlo...@yahoo-inc.com>> Cc: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>>, Sean Dague <s...@dague.net<mailto:s...@dague.net>> Subject: Re: [openstack-dev] [requirements] - taskflow preventing sqla 0.8 upgrade On Fri, Jan 3, 2014 at 12:45 PM, Joshua Harlow <harlo...@yahoo-inc.com<mailto:harlo...@yahoo-inc.com>> wrote: Ok, I think I'm fine with that (although not really sure what that entails). What does the living under the 'oslo program' change? Does that entail getting sucked into the incubator (which seems to be what your graduating link is about). I don't think its a good idea for taskflow to be in the 'incubator'. Taskflow is meant to be just like any other 3rd party library. No, as we discussed in Hong Kong, there's no reason to add taskflow to the incubator. Whether or not it needs to be part of the oslo program (or any other program) is a separate question. I'm not opposed to bringing it in, but didn't see the point when it came up at the summit. I understand that moving taskflow into oslo would avoid the policy decision we have in place to not do symmetric gating on unreleased versions of things not "owned" by the OpenStack project. However, I don't know if we want to be testing against the git head of libraries no matter where they live. As fungi pointed out on IRC, gating against pre-release versions of libraries may allow us to reach a state where the software works when installed from git, but not from the released packages. It seems safer to gate changes to libraries against the apps' trunk (to avoid making backwards-incompatible changes), and then gate changes to the apps against the released libraries (to ensure they work with something available to be packaged by the distros). There are lots and lots of version numbers available to us, so I see no problem with releasing new versions of libraries frequently. Am I missing something that makes that not work? Doug Or were u mainly referring to the 'devstack-gate integration' section? I'd be interested in hearing dougs opinion here (cc'd him) as https://etherpad.openstack.org/p/icehouse-oslo-splitting-the-incubator would seem to cause even more of these types of new 3rd party libraries to appear on pypi (and therefore causing similar issues of transitive dependencies as taskflow). Will bug u on #openstack-infra soon :-) On 1/3/14, 9:05 AM, "Sean Dague" <s...@dague.net<mailto:s...@dague.net>> wrote: >On 01/03/2014 11:37 AM, Joshua Harlow wrote: >> So taskflow was tested with the version of sqlalchemy that was available >> and in the requirements at the time of its 0.1 release (taskflow syncs >> it's requirements from the same global requirements). From what I >> remember this is the same requirement that everyone else is bound to: >> >> SQLAlchemy>=0.7.8,<=0.7.99 >> >> I can unpin it if this is desired (the openstack requirements repo has >> the same version restriction). What would be recommended here? As more >> code moves to pypi reusable libraries (oslo.db when it arrives comes to >> mind) I think this will be hit more often. Let's come up with a good >> strategy to follow. >> >> Thoughts?? > >So I think that given taskflow's usage, it really needs to live under >the Oslo program, and follow the same rules that are applied to oslo >libraries. (https://wiki.openstack.org/wiki/Oslo#Graduation) > >Which means it needs to be part of the integrated gate, so we can update >it's requirements globally. It also means that changes to it will be >gated on full devstack runs. > >We can work through the details on #openstack-infra. ttx has been doing >the same for oslo.rootwrap this week. > > -Sean > >-- >Sean Dague >Samsung Research America >s...@dague.net<mailto:s...@dague.net> / >sean.da...@samsung.com<mailto:sean.da...@samsung.com> >http://dague.net > >_______________________________________________ >OpenStack-dev mailing list >OpenStack-dev@lists.openstack.org<mailto:OpenStack-dev@lists.openstack.org> >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
