Actually grenade has always run under errexit, devstack just had enough legacy cruft in it that it took a while to get it to run clean.
-Sean On 02/28/2014 09:13 AM, Mauro S M Rodrigues wrote: > Awesome! thanks for it! > > Btw I guess this will automatically works for grenade, since we use > devstack to setup X-1 release, am I right? (and it's not a concern for > the upgrade part since the upgrade-<component> scripts already contain > errexit trap on the cleanup functions right?) > > -- > mauro(sr) > > > On 02/27/2014 06:17 PM, Sergey Lukjanov wrote: >> And a big +1 from me too. It's really useful. >> >> On Fri, Feb 28, 2014 at 12:15 AM, Devananda van der Veen >> <devananda....@gmail.com> wrote: >>> Thu, Feb 27, 2014 at 9:34 AM, Ben Nemec <openst...@nemebean.com> >>> wrote: >>>> On 2014-02-27 09:23, Daniel P. Berrange wrote: >>>>> On Thu, Feb 27, 2014 at 08:38:22AM -0500, Sean Dague wrote: >>>>>> This patch is coming through the gate this morning - >>>>>> https://review.openstack.org/#/c/71996/ >>>>>> >>>>>> The point being to actually make devstack stop when it hits an error, >>>>>> instead of only once these compound to the point where there is no >>>>>> moving forward and some service call fails. This should >>>>>> *dramatically* >>>>>> improve the experience of figuring out a failure in the gate, because >>>>>> where it fails should be the issue. (It also made us figure out some >>>>>> wonkiness with stdout buffering, that was making debug difficult). >>>>>> >>>>>> This works on all the content that devstack gates against. However, >>>>>> there are a ton of other paths in devstack, including vendor plugins, >>>>>> which I'm sure aren't clean enough to run under -o errexit. So if >>>>>> all of >>>>>> a sudden things start failing, this may be why. Fortunately you'll be >>>>>> pointed at the exact point of the fail. >>>>> >>>>> This is awesome! >>>> >>>> +1! Thanks Sean and everyone else who was involved with this. >>> >>> Another big +1 for this! I've wished for it every time I tried to add >>> something to devstack and struggled with debugging it. >>> >>> -Deva >>> >>> _______________________________________________ >>> OpenStack-dev mailing list >>> OpenStack-dev@lists.openstack.org >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> >> >> > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sean Dague Samsung Research America s...@dague.net / sean.da...@samsung.com http://dague.net
signature.asc
Description: OpenPGP digital signature
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev