+1 to all Ben said. There are reasons to split things up in to a logical progression of changes but each change must stand alone and must pass tests.
Carl On Mon, Mar 24, 2014 at 10:03 AM, Ben Nemec <openst...@nemebean.com> wrote: > I should point out that Jenkins can't apply the next patch in sequence > just to get tests passing. What happens if the next patch never merges > or has to be reverted? Each commit needs to be able to pass tests using > only the previous commits in the sequence. If it relies on a subsequent > commit then either the commits need to be reordered or, if there's a > circular dependency, maybe those commits aren't logically separate and > should just be squashed together. _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
