On 14/04/14 19:51, Kevin Benton wrote: > Hi Mario, > > Here is the problem: >>>> import netaddr >>>> p = netaddr.IPNetwork('2001:0db8::/64') >>>> str(p) > '2001:db8::/64' > > Now that you are converting CIDR strings to netaddr objects and back, it's > causing redundant info to be dropped. You will just have to remove the > references to 2001:0db8::/64 and replace them with 2001:db8::/64.
thanks so much! This did it and the tests now pass ok. When we meet (I won't be at Atlanta unfortunately, hopefully next one) I owe you at *least* one beer ;) thanks, marios > > I will comment on the review as well. > > Cheers, > Kevin Benton > > > On Mon, Apr 14, 2014 at 9:23 AM, mar...@redhat.com <mandr...@redhat.com>wrote: > >> Hi, >> >> I am really stumped by a Jenkins failure for one of my reviews... @ >> https://review.openstack.org/#/c/59212/ if any kind soul has any >> pointers/help I will be very grateful. The strange thing is that Jenkins >> +1 this patchset (Apr 2) but subsequently failed as described below: >> >> The failure is from >> >> neutron.tests.unit.test_security_groups_rpc.SGServerRpcCallBackMixinTestCase >> and specifically the 2 test cases >> test_security_group_rules_for_devices_ipv6_ingress and >> test_security_group_rules_for_devices_ipv6_egress >> >> The failure is on the assertion at the end of the methods: >> >> self.assertEqual(port_rpc['security_group_rules'],expected) >> >> port_rpc['security_group_rules'] ---> {'ethertype': u'IPv6', >> 'direction': u'egress' >> expected ---> {'ethertype': 'IPv6', 'direction': >> 'egress' >> >> (you can see this in the logs, e.g. >> >> http://logs.openstack.org/12/59212/14/check/gate-neutron-python27/57d89d5/console.html.gz >> ) >> >> >> I have *no* idea what in my code is causing this behaviour; if I just >> grab this review, the tests pass fine. But if I rebase against master, >> they fail, i.e.: >> >> git review -d I71fb8c887963a122a5bd8cfdda800026c1cd3954 >> source .tox/py27/bin/activate >> ./run_tests.sh -d >> >> neutron.tests.unit.test_security_groups_rpc.SGServerRpcCallBackMixinTestCase >> >> ... >> >> Ran 7 tests in 1.926s >> OK >> >> ... >> >> git rebase master >> ./run_tests.sh -d >> >> neutron.tests.unit.test_security_groups_rpc.SGServerRpcCallBackMixinTestCase >> >> ... >> >> Ran 11 tests in 2.964s >> FAILED (failures=2) >> >> ... >> >> thanks for reading, if you came this far! >> >> marios >> >> _______________________________________________ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev