On 4/28/2014 3:03 PM, Denis Makogon wrote:
Good day, Boden.
I think you should file the blueprint for it and put it into BP meeting
agenda.
Best regards,
Denis Makogon
On Mon, Apr 28, 2014 at 9:50 PM, boden <bo...@linux.vnet.ibm.com
<mailto:bo...@linux.vnet.ibm.com>> wrote:
Guys,
I have a few small features / enhancements I'd like to suggest. I'm
willing to contribute the code / unit tests myself, but am looking
for a consensus from the group before I invest the time.
There are a few enhancements on my list -- I will send details each
in a separate email to keep the communication clearer.
I'd like to propose the ability to support a pluggable trove
conductor manager. Currently the trove conductor manager is
hard-coded [1][2] and thus is always
'trove.conductor.manager.__Manager'. I'd like to see this conductor
manager class be pluggable like nova does [3].
I'm thinking the same approach nova took:
(a) Add a conductor section to the trove-conductor.conf with a
property to specify the conductor manager class... e.g.
[conductor]
manager = package.of.conductor.manager.__Manager
(b) Default trove's CONF value for conductor.manager to the existing
manager trove.conductor.manager.__Manager which ensures backwards
compat.
(c) In trove.cmd.conductor.py <http://trove.cmd.conductor.py> create
the RpcService using the conf value. e.g.
server = rpc_service.RpcService(__manager=CONF.conductor.__manager,
topic=topic)
The above will allow consumers to extend / plug into the conductor
manager without upstream changes.
Any disagreement / comments on this enhancement? Again -- I can
contribute the code, unless someone is bored and wants to run with
it short-term.
Thanks
[1]
https://github.com/openstack/__trove/blob/master/trove/cmd/__conductor.py#L40
<https://github.com/openstack/trove/blob/master/trove/cmd/conductor.py#L40>
[2]
https://github.com/openstack/__trove/blob/master/trove/cmd/__conductor.py#L42
<https://github.com/openstack/trove/blob/master/trove/cmd/conductor.py#L42>
[3]
https://github.com/openstack/__nova/blob/master/nova/cmd/__conductor.py#L43
<https://github.com/openstack/nova/blob/master/nova/cmd/conductor.py#L43>
_________________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.__org
<mailto:OpenStack-dev@lists.openstack.org>
http://lists.openstack.org/__cgi-bin/mailman/listinfo/__openstack-dev
<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Denis thanks...
Done, and done --
https://blueprints.launchpad.net/trove/+spec/pluggable-conductor-manager
https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting#Weekly_Trove_Blueprint_Meeting
I missed today's BP meeting, but I will plan to attend the next one.
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
