Regarding config opts for keystone, the keystoneclient middleware already registers the opts at https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325under a keystone_authtoken group in the config file. Currently, Mistral registers the opts again at https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108under a different configuration group. Should we remove the duplicate from Mistral and refactor the reference to keystone configurations to the keystone_authtoken group? This seems more consistent.
On Thu, May 15, 2014 at 1:13 PM, W Chan <m4d.co...@gmail.com> wrote: > Currently, the various configurations are registered in > ./mistral/config.py. The configurations are registered when mistral.config > is referenced. Given the way the code is written, PEP8 throws referenced > but not used error if mistral.config is referenced but not called in the > module. In various use cases, this is avoided by using importutils to > import mistral.config (i.e. > https://github.com/stackforge/mistral/blob/master/mistral/tests/unit/engine/test_transport.py#L34). > I want to break down registration code in ./mistral/config.py into > separate functions for api, engine, db, etc and move the registration > closer to the module where the configuration is needed. Any objections? >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
