On 08/17/2014 05:40 PM, Nathan Kinder wrote: > > > On 08/17/2014 01:58 PM, Matt Riedemann wrote: >> >> >> On 8/17/2014 3:36 PM, Alan Pevec wrote: >>> 2014-08-17 22:25 GMT+02:00 Matt Riedemann <mrie...@linux.vnet.ibm.com>: >>>> The other thing I thought was we could cap the version of >>>> python-keystoneclient in stable/havana, would that be bad? >>>> stable/havana is >>>> going to be end of life pretty soon anyway. >>> >>> No, we had cap on some clients and it was creating situations with >>> conflicting requirements, last example was swiftclient<2. >>> Another alternative was to start stable/* from clients but that was >>> rejected in the past. >>> Theory is that *clients are backward compatible but I'm not sure if >>> addition of new dependencies was considered when decision to go with >>> master-only clients was made. >>> >>> I think it's fine to add new test-requirements on stable, we should >>> just somehow get an early warning that client change is going to break >>> stable branch and update test-req preemptively. >>> >>> Cheers, >>> Alan >>> >> >> OK, so here is where we appear to be: >> >> 1. We need the oslo.utils changes in python-keystoneclient reverted on >> master to get the stable/havana backports for global-requirements to >> pass Jenkins. The revert is here: >> >> https://review.openstack.org/#/q/status:open+project:openstack/python-keystoneclient+branch:master+topic:bug/1357652,n,z >> >> >> 2. The backports for oslo.i18n and oslo.utils to stable/havana are here: >> >> https://review.openstack.org/#/q/status:open+project:openstack/requirements+branch:stable/havana+topic:bug/1357652,n,z > > Jenkins is failing for stable/icehouse because of oslo.utils too: > > https://review.openstack.org/113744 > > What seems odd is that oslo.utils was already added to > global-requirements.txt for stable/icehouse: > > https://review.openstack.org/#/c/112337/ > > Despite the above global-requirements.txt change, the tests are still > failing. It seems like something more will be needed to get the tests > passing for both stable/icehouse and stable/havana.
I see that Brant has already proposed adding oslo.utils to test-requirements.txt for keystone in stable/havana and stable/icehouse, which should take care of these failures: havana - https://review.openstack.org/#/c/114846/ icehouse - https://review.openstack.org/#/c/114845/ > >> >> >> 3. Once 1 and 2 are done, we can restore the changes to >> python-keystoneclient on master. >> > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
