Thanks Mike, I already gave your patch a +2. when the gate is broken there's no time for nitpicking - those can come with a followup patch. The patch is now spinning again against jenkins checks. As soon as it's done we'll send it through the gate - and hopefully get a promotion for it.
Salvatore On 3 December 2014 at 23:17, Mike Bayer <mba...@redhat.com> wrote: > So folks, I had to put Alembic 0.7.1 out as I realized that the “batch” > mode was being turned on for autogenerate across the board in 0.7.0, and > that was not the plan. > > So it is now out, and the builds are failing due to > https://launchpad.net/bugs/1397796. > > There’s some nits happening on the review > https://review.openstack.org/#/c/137989/, so I’m hoping someone with some > Neutron cred adjust the patch to their liking and get it merged. I’m > just the messenger on this. > > - mike > > > > On Dec 1, 2014, at 5:43 PM, Salvatore Orlando <sorla...@nicira.com> wrote: > > Thanks Mike! > > I've left some comments on the patch. > Just out of curiosity, since now alembic can autogenerate foreign keys, > are we be able to remove the logic for identifying foreign keys to > add/remove [1]? > > Salvatore > > [1] > http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/migration/alembic_migrations/heal_script.py#n205 > > > On 1 December 2014 at 20:35, Mike Bayer <mba...@redhat.com> wrote: > >> hey neutron - >> >> Just an FYI, I’ve added https://review.openstack.org/#/c/137989/ / >> https://launchpad.net/bugs/1397796 to refer to an issue in neutron’s >> “heal” script that is going to start failing when I put out Alembic 0.7.1, >> which is potentially later today / this week. >> >> The issue is pretty straightforward, Alembic 0.7.1 is adding foreign key >> autogenerate (and really, could add more types of autogenerate at any >> time), and as these new commands are revealed within the >> execute_alembic_command(), they are not accounted for, so it fails. I’d >> recommend folks try to push this one through or otherwise decide how this >> issue (which should be expected to occur many more times) should be handled. >> >> Just a heads up in case you start seeing builds failing! >> >> - mike >> >> >> >> _______________________________________________ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev