I've envisioned basically the same feature before, but I don't find the comments to be particularly useful without the complete context.
What I really want from gerrit is a 3-way diff, wherein the first column is always the original state of the repo, the second column is a user-selectable patchset between (patchset 1) and (latest patchset - 1), and the third column is always the (latest patchset). And then make it easy for me to switch the middle column to a different patchset, without scrolling back to the top of the page. You'd be able to quickly skim through the history of comments and see the evolution of a patch, which I think is the same user experience that you're looking for? I agree with Jeremy though, this is ideally an upstream effort to improve gerrit itself. On Tue, Dec 16, 2014 at 4:27 AM, Radoslav Gerganov <rgerga...@vmware.com> wrote: > I never liked how Gerrit is displaying inline comments and I find it hard > to follow discussions on changes with many patch sets and inline comments. > So I tried to hack together an html view which display all comments grouped > by patch set, file and commented line. You can see the result at > http://gerrit-mirror.appspot.com/<change-id>. Some examples: > > http://gerrit-mirror.appspot.com/127283 > http://gerrit-mirror.appspot.com/128508 > http://gerrit-mirror.appspot.com/83207 > > There is room for many improvements (my css skills are very limited) but I > am just curious if someone else finds the idea useful. The frontend is > using the same APIs as the Gerrit UI and the backend running on > GoogleAppEngine is just proxying the requests to review.openstack.org. So > in theory if we serve the html page from our Gerrit it will work. You can > find all sources here: https://github.com/rgerganov/gerrit-hacks. Let me > know what you think. > > Thanks, > Rado > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
