Qiming, you are reading bits and pieces of my responses."if you checkout the review" guess i give up!
-- dims On Wed, Jan 21, 2015 at 11:18 PM, Qiming Teng <teng...@linux.vnet.ibm.com> wrote: > On Wed, Jan 21, 2015 at 10:55:37AM -0500, Davanum Srinivas wrote: >> Qiming, >> >> Guessing you were looking at master. if you checkout the review i >> pointed to, you will see what others on the thread have pointed you >> to: >> https://github.com/openstack/oslo.log/blob/master/doc/source/usage.rst >> >> We are using register_options and setup. we should be adding >> register_options in the future as need arises. > > In most files listed below, the 'logging' refers to > nova/openstack/common/log.py instead of oslo_log/log.py. No project can > throw away openstack/common/log.py at the moment, because it breaks > things in many ways. > >> dims@dims-mac:~/openstack/nova$ find . -name "*.py" -exec grep -H >> logging {} \; | grep -e "\.setup" -e "\.register_options" -e >> "\.set_defaults" >> ./nova/cmd/all.py: logging.setup(CONF, "nova") >> ./nova/cmd/api.py: logging.setup(CONF, "nova") >> ./nova/cmd/api_ec2.py: logging.setup(CONF, "nova") >> ./nova/cmd/api_metadata.py: logging.setup(CONF, "nova") >> ./nova/cmd/api_os_compute.py: logging.setup(CONF, "nova") >> ./nova/cmd/cells.py: logging.setup(CONF, 'nova') >> ./nova/cmd/cert.py: logging.setup(CONF, "nova") >> ./nova/cmd/compute.py: logging.setup(CONF, 'nova') >> ./nova/cmd/conductor.py: logging.setup(CONF, "nova") >> ./nova/cmd/console.py: logging.setup(CONF, "nova") >> ./nova/cmd/consoleauth.py: logging.setup(CONF, "nova") >> ./nova/cmd/dhcpbridge.py: logging.setup(CONF, "nova") >> ./nova/cmd/manage.py: logging.setup(CONF, "nova") >> ./nova/cmd/network.py: logging.setup(CONF, "nova") >> ./nova/cmd/novncproxy.py: logging.setup(CONF, "nova") >> ./nova/cmd/novncproxy.py: logging.setup(CONF, "nova") >> ./nova/cmd/objectstore.py: logging.setup(config.CONF, "nova") >> ./nova/cmd/scheduler.py: logging.setup(CONF, "nova") >> ./nova/cmd/serialproxy.py: logging.setup(CONF, "nova") >> ./nova/cmd/spicehtml5proxy.py: logging.setup(CONF, "nova") >> ./nova/cmd/xvpvncproxy.py: logging.setup(config.CONF, "nova") >> ./nova/openstack/common/report/guru_meditation_report.py: >> logging.setup(CONF, 'blah') >> ./nova/test.py:logging.register_options(CONF) >> ./nova/test.py:logging.setup(CONF, 'nova') >> >> If you file a review with what you have, maybe we can help, again, pop >> onto the #openstack-oslo channel to ask > > Okay, will do. Thanks. > > Regards, > Qiming > >> -- dims >> >> On Wed, Jan 21, 2015 at 10:25 AM, Qiming Teng >> <teng...@linux.vnet.ibm.com> wrote: >> > On Wed, Jan 21, 2015 at 08:25:57AM -0500, Davanum Srinivas wrote: >> >> Qiming, >> >> >> >> Nova already uses oslo.config. there's a patch against nova to use >> >> oslo_log. Doug took the effort to do this so we'd not face issues once >> >> we release oslo_log, so yes, they have been tested together. Please >> >> hop onto #openstack-oslo to debug in real time. >> >> >> >> [1] https://review.openstack.org/#/c/147635/ >> >> >> > >> > Well, just checked nova code, it seems openstack.common.log is still >> > there. That means there are duplicated code such as the >> > 'common_cli_opts' which resides in both openstack.common.log and >> > oslo_log._options. >> > >> > I was getting the following error if I'm deleting openstack.common.log >> > module: >> > >> > oslo_config.cfg.NoSuchOptError: no such option: log_config_append >> > >> > So ... even with oslo_log there, we still need openstack.common.log? >> > Pretty confused and a little frustrated after two days of digging. >> > >> > Regards, >> > Qiming >> > > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev