Sean, thanks! I feel better already. I'll check out the review.
Trevor On Tue, 2015-02-24 at 14:39 -0500, Sean Dague wrote: > On 02/24/2015 02:34 PM, Trevor McKay wrote: > > Hi folks, > > > > I've just joined the stable maintenance team for Sahara. > > > > We have this review here, from OpenStack proposal bot: > > > > https://review.openstack.org/158775/ > > > > Since it came from the proposal bot, there's no justification in the > > commit message and no cherry pick. > > > > I didn't see this case covered as one of the strict set in > > > > https://wiki.openstack.org/wiki/StableBranch > > > > Do we trust the proposal bot? How do I know I should trust it? On > > master, I assume if there > > is a mistake it will soon be rectified, but stable ... Do we have a doc > > that talks about stable maintenance > > and requirements changes? Should we? > > > > Am I being paranoid? :) > > Slightly, but that's probably good. > > Requirements proposal bot changes had to first be Approved on the > corresponding requirements stable branch, so that should be both safe, > and mandatory to go in. > > I agree that it would be nicer to have more justification in there. > There is the beginning of the patch up to do something a bit better here > - https://review.openstack.org/#/c/145932/ - though it could use to be > improved. > > -Sean > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev