On Thu, Mar 05, 2015 at 07:39:23PM +0000, Murray, Paul (HP Cloud) wrote: > Hi All, > > I know Yunhong Jiang and Daniel Berrange have been involved in the following, > but I thought it worth sending to the list for visibility. > > While writing code to convert the resource tracker to use the ComputeNode > object realized that the api samples used in the functional tests are not the > same as the format as the PciDevicePool object. For example: > hypervisor-pci-detail-resp.json has something like this: > > "os-pci:pci_stats": [ > { > "count": 5, > "extra_info": { > "key1": "value1", > "phys_function": "[[\"0x0000\", \"0x04\", \"0x00\", \"0x1\"]]" > }, > "keya": "valuea", > "product_id": "1520", > "vendor_id": "8086" > } > ], > > My understanding from interactions with yjiang5 in the past leads me to think > that something like this is what is actually expected: > > "os-pci:pci_stats": [ > { > "count": 5, > "key1": "value1", > "phys_function": "[[\"0x0000\", \"0x04\", \"0x00\", \"0x1\"]]", > "keya": "valuea", > "product_id": "1520", > "vendor_id": "8086" > } > ], > > This is the way the PciDevicePool object expects the data structure to be and > is also the way the libvirt virt driver creates pci device information (i.e. > without the "extra_info" key). Other than that (which is actually pretty > clear) I couldn't find anything to tell me definitively if my interpretation > is correct and I don't want to change the functional tests without being sure > they are wrong. So if anyone can give some guidance here I would appreciate > it.
I'm afraid I've not actually done any work with the PCI support at the API level - only looked at the data reported by the hypervisors in the get_available_resource method which isn't API sensitive as its internal code. So probably need someone else to answer these questions. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev