On 04/24/2015 04:14 AM, Julien Danjou wrote:
Hi there,
This is now happening weekly to me now, probably because I write too
many patches touching almost all OpenStack projects once a cycle, and
I'm really tired of that behavior, so PLEASE:
*Stop sending Code-Review-1 when asking a question in a patch*
Counterpoint: If you don't, you will not get a response from the author.
Too much information, too much churn, but a -1 demands a r response, and
0 does not.
Perhaps if we could separately indicate a question that needs to be
answered from a "do not merge" message, this would change....something
like:
Q: "Is Foo the bar?" sets the question flag.
Me: "No Foo is not the bar." Indicates that I think I have answered the
question and clears the flag.
Q then gets notification, and can say yes or no. If unanswered after a
day/week, the Flag is automatically cleared.
But...that is what -1 is for. It means: don't merge until my question
is answered. If an author could mark that they feel they've addressed
the -1 without a resubmission, it would take the stink off the -1.
_Sometimes_ there are good reasons to set -1 even when asking a
question. For example, when the question is a hint sent to the patch
author so that (s)he improves is commit message, a code comment or a
piece of code.
But most of the time, if you ask a question because there's something
YOU DO NOT KNOW OR UNDERSTAND, do not put a score to a patchset. You
don't know the answer, so you have absolutely no right to evaluate a
patchset with -1. Just don't set a score, it's OK, and wait for the
answer before deciding if the patch is worth [-1..+2].
Thank you for listening, and happy hacking!
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
