-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 05/26/2015 11:53 PM, Kevin Benton wrote: >> Actually, that approach was initially taken for bug 1345947, but > then the patch was abandoned to be replaced with a simpler - > --dhcp-authoritative approach that ended up with unexpected NAKs > for multi agent setup. > >> See: https://review.openstack.org/#/c/108272/12 > > So I had seen that patch but it's quite different from the approach > I was taking. That one requires a new script in the 'bin' > directory, a new entry in setup.cfg, an a new dhcp filter entry for > rootwrap. Is that something you would be comfortable back-porting > all of the way back to Icehouse?
I agree that a patch without a new script and, more importantly, without a rootwrap filter modification, is a lot better than the one I cited above. > > The approach I was using was to generate the script at runtime in > the data directory for each instance to just return the addresses > directly. That way there are no setup changes or new entries in > bin. Personally, I felt it was easier to understand since it simply > generated a big echo statement, but I might be biased because I > wrote it. :) > Looking at [1], I don't see that it generates a script at all. What it does is it prepopulates a lease file for dnsmasq consumption (so there is no external shell involved). Do we talk about the same patch? I've checked [1], and it seems like the best approach, both from code complexity and "backportability" perspective. I've left some comments there. [1]: https://review.openstack.org/#/c/185486/ Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZbE8AAoJEC5aWaUY1u57ufkH/RfsQJy+Ddz3f+L37mNY28uj h+gLaiJIcZ1iMKKMo1tpg881u/aKpy3LlScoKHLnwWXub/IPxrxN2+/IMfCoF9iV ZbgtmggVRh/TjHOMbMpQVqJ+J8qe4TN29kW5x1RcUEecYy/hbyyKeBYoLlEXoZhn GzWcWyx9yp2qSOqe9010K+nmXdAzD+jg8/YJlBtP/ggO0qoWB7Is/D2bHkoeCPsd uqJzhAAZg4w2hhPgKpb1aUhyQU9uE5gzj5Yh5PE+kvINDRwLTLoqWQ7sxpR1hiqH rZ8t8FE1wmdQKEWrsRVy6/2pLOziKVNGPinBLYwwBUGY+S7kb2Jc6AgAHrAx/iY= =Wnx+ -----END PGP SIGNATURE----- __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev