After thinking about this for a while, I came to think, that we also need a jslinter job for murano-dashboard. Horizon is currently adopting eslint as a one tool for the job (meant to replace jscs and jshint afaiu), so we could adopt this as part of the blueprint, I filed.
-- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 15 Jun 2015 at 02:27:06, Kirill Zaitsev (kzait...@mirantis.com) wrote: Since there were no objections, and as a follow-up I’ve created a BP for that in murano: https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 10 Jun 2015 at 18:07:19, Filip Blaha (filip.bl...@hp.com) wrote: Thanks for comment and suggestion! there is also shutil2 framework for unit testing over shell scripts. We shall consider it whether it could bring us value for the effort. I personally have no strong opinion about that. Little contradiction to my previous mail:-) Regards Filip On 06/10/2015 03:34 PM, Jeremy Stanley wrote: > On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: >> +1, nice idea. Shell script are not easy to review - large files, not >> covered by unit tests. Any automatic tool could be beneficial. > It's worth noting that just because your shell scripts don't have > their own validation tests doesn't mean they can't. For example see > the test-features.sh and test-functions.sh scripts in the > https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo, > making sure we maintain a contract on things like branch fallback > logic which is easy to subtly break if not tested. __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
