Hi, I agree with Sergii, the patch had some problems only with tests which are already resolved. So I vote for FFE.
P.S. We've just merged it. Regards, Alex On Mon, Jul 27, 2015 at 3:30 PM, Sergii Golovatiuk <sgolovat...@mirantis.com > wrote: > Hi, > > I have checked the code. After fixing tests, this patch maybe included to > FFE as it has minimal impact on core functionality. +1 for FFE for > https://review.openstack.org/#/c/196114/ > > -- > Best regards, > Sergii Golovatiuk, > Skype #golserge > IRC #holser > > On Mon, Jul 27, 2015 at 1:38 PM, Vladimir Kuklin <vkuk...@mirantis.com> > wrote: > >> There is a slight change needed, e.g. fixing of noop tests. Then we can >> merge it and accept for FFE, I think. >> >> On Fri, Jul 24, 2015 at 1:34 PM, Andrian Noga <an...@mirantis.com> wrote: >> >>> Colleagues, >>> actually, i'm tottaly agree with Mike. We can merge >>> https://review.openstack.org/#/c/196114/ w/o additional Ceilometer >>> support (will be moved to next release). So if we merge it today we dont >>> need FFE for this feature. >>> >>> >>> Regards, >>> Andrian >>> >>> On Fri, Jul 24, 2015 at 1:18 AM, Mike Scherbakov < >>> mscherba...@mirantis.com> wrote: >>> >>>> Since we are in FF state already, I'd like to have urgent estimate from >>>> one of fuel-library cores: >>>> - holser >>>> - alex_didenko >>>> - aglarendil >>>> - bogdando >>>> >>>> aglarendil is on vacation though. Guys, please take a look at >>>> https://review.openstack.org/#/c/196114/ - can we accept it as >>>> exception? Seems to be good to go... >>>> >>>> I still think that additional Ceilometer support should be moved to the >>>> next release. >>>> >>>> Thanks, >>>> >>>> On Thu, Jul 23, 2015 at 1:56 PM Mike Scherbakov < >>>> mscherba...@mirantis.com> wrote: >>>> >>>>> Hi Andrian, >>>>> this is High priority blueprint [1] for 7.0 timeframe. It seems we >>>>> still didn't merge the main part [2], and need FF exception for additional >>>>> stuff. >>>>> >>>>> The question is about quality. If we focus on enhancements, then we >>>>> don't focus on bugs. Which whether means to deliver work with lower >>>>> quality >>>>> of slip the release. >>>>> >>>>> My opinion is rather don't give FF exception in this case, and don't >>>>> have Ceilometer support for this new feature. >>>>> >>>>> [1] https://blueprints.launchpad.net/fuel/+spec/compute-vmware-role >>>>> [2] https://review.openstack.org/#/c/196114/ >>>>> >>>>> On Thu, Jul 23, 2015 at 1:39 PM Andrian Noga <an...@mirantis.com> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> The patch patch for fuel-library >>>>>> <https://review.openstack.org/#/c/196114/> that implements >>>>>> 'compute-vwmare' role (https://mirantis.jira.com/browse/PROD-627) >>>>>> requires >>>>>> additional work to do (ceilometer support.), but as far as I can see it >>>>>> doesn't affect any other parts of the product. >>>>>> >>>>>> We plan to implement it in 3 working days (2 for implementation, 1 >>>>>> day for writing system test and test runs), it should not be hard since >>>>>> we >>>>>> already support ceilometer compute agent deployment on controller >>>>>> nodes. >>>>>> >>>>>> We need 1 DevOps engineer and 1 QA engineer to be engaged for this >>>>>> work. >>>>>> >>>>>> So I think it's ok to accept this feature as an exception for feature >>>>>> freeze. >>>>>> >>>>>> Regards, >>>>>> Andrian Noga >>>>>> Project manager >>>>>> Partner Centric Engineering >>>>>> Mirantis, Inc >>>>>> >>>>>> Mob.phone: +38 (063) 966-21-24 >>>>>> >>>>>> Email: an...@mirantis.com >>>>>> Skype: bigfoot_ua >>>>>> >>>>> -- >>>>> Mike Scherbakov >>>>> #mihgen >>>>> >>>> -- >>>> Mike Scherbakov >>>> #mihgen >>>> >>> >>> >>> >>> -- >>> -- >>> Regards, >>> Andrian >>> Mirantis, Inc >>> >>> Mob.phone: +38 (063) 966-21-24 >>> Email: an...@mirantis.com >>> Skype: bigfoot_ua >>> >>> >>> __________________________________________________________________________ >>> OpenStack Development Mailing List (not for usage questions) >>> Unsubscribe: >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> >>> >> >> >> -- >> Yours Faithfully, >> Vladimir Kuklin, >> Fuel Library Tech Lead, >> Mirantis, Inc. >> +7 (495) 640-49-04 >> +7 (926) 702-39-68 >> Skype kuklinvv >> 35bk3, Vorontsovskaya Str. >> Moscow, Russia, >> www.mirantis.com <http://www.mirantis.ru/> >> www.mirantis.ru >> vkuk...@mirantis.com >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev